make sure that we actually need to run the datalog engine #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the authorizer needs the datalog engine to have executed before performing certain tasks, but we might have already done it precedently, without having added facts or rules. This adds a boolean tracking if we need to run: if we added facts or rules, it is set to true, if we have just run the datalog engine, it is set to false
divarvel
reviewed
Dec 28, 2023
| @@ -218,33 +222,38 @@ impl Authorizer { | |||
| /// Add the rules, facts, checks, and policies of another `Authorizer`. | |||
| /// If a token has already been added to `other`, it is not merged into `self`. | |||
| pub fn merge(&mut self, mut other: Authorizer) { | |||
| self.dirty = true; | |||
There was a problem hiding this comment.
this one is redundant, but better safe than sorry, I guess
CodSpeed Performance ReportMerging #197 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 67.47% 67.48%
=======================================
Files 25 25
Lines 5347 5370 +23
=======================================
+ Hits 3608 3624 +16
- Misses 1739 1746 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the authorizer needs the datalog engine to have executed before performing certain tasks, but we might have already done it precedently, without having added facts or rules.
This adds a boolean tracking if we need to run: if we added facts or rules, it is set to true, if we have just run the datalog engine, it is set to false