Better display for errors::Logic
#191
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
divarvel
commented
Oct 26, 2023
•
divarvel
commented
divarvel
commented
Oct 26, 2023
| @@ -168,9 +171,9 @@ pub enum Signature { | |||
| #[derive(Error, Clone, Debug, PartialEq, Eq)] | |||
| #[cfg_attr(feature = "serde-error", derive(serde::Serialize, serde::Deserialize))] | |||
| pub enum Logic { | |||
| #[error("a rule provided by a block is generating facts with the authority or ambient tag, or has head variables not used in its body")] | |||
| #[error("a rule provided by a block is producing a fact with unbound variables")] | |||
There was a problem hiding this comment.
i wanted to completely remove it, but it's still used. the strange thing is that it explicitly mentions block rules. Where is the error for authorizer rules with unbound variables in facts?
divarvel
changed the title
divarvel
changed the title
errors::Logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.