Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ecdsa signatures #108

Open
wants to merge 30 commits into
base: v5
Choose a base branch
from
Open

add support for ecdsa signatures #108

wants to merge 30 commits into from

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Oct 11, 2022

@Geal Geal changed the base branch from main to v5 May 23, 2024 07:38
Geal added 8 commits May 23, 2024 09:39
Since we can now have multiple algorithms, we cannot know during
deserialization the right size of a signature, so that check is now
removed. A signature with an invalid size will generate an error later
during verification anyway
@Geal Geal marked this pull request as ready for review May 23, 2024 12:40
Copy link

codspeed-hq bot commented May 26, 2024

CodSpeed Performance Report

Merging #108 will not alter performance

Comparing fipscuit (c88fff0) with v5 (3e3f071)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 67.45407% with 124 lines in your changes are missing coverage. Please review.

Project coverage is 68.18%. Comparing base (3e3f071) to head (c88fff0).

Files Patch % Lines
biscuit-auth/src/crypto/ed25519.rs 53.16% 37 Missing ⚠️
biscuit-auth/src/crypto/p256.rs 54.05% 34 Missing ⚠️
biscuit-auth/src/crypto/mod.rs 78.49% 20 Missing ⚠️
biscuit-auth/src/token/unverified.rs 0.00% 16 Missing ⚠️
biscuit-auth/src/capi.rs 0.00% 4 Missing ⚠️
biscuit-parser/src/builder.rs 0.00% 4 Missing ⚠️
biscuit-auth/src/token/mod.rs 80.00% 3 Missing ⚠️
biscuit-auth/examples/third_party.rs 0.00% 2 Missing ⚠️
biscuit-auth/src/token/builder.rs 81.81% 2 Missing ⚠️
biscuit-auth/examples/testcases.rs 98.36% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##               v5     #108      +/-   ##
==========================================
+ Coverage   67.91%   68.18%   +0.27%     
==========================================
  Files          25       27       +2     
  Lines        5507     5689     +182     
==========================================
+ Hits         3740     3879     +139     
- Misses       1767     1810      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant