fix: patch to production app for dev projects page - DO NOT MERGE #4689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
BioSimulations
eagmon
approved these changes
May 31, 2023
| @@ -13,15 +13,15 @@ | |||
| heading="Simulation projects" | |||
| icon="project" | |||
| id="trigger" | |||
| [routerLink]="['/projects']" | |||
| [href]="config.platformAppProjectsUrl" | |||
There was a problem hiding this comment.
yes, the code change is easy - the corresponding monkey-patch would have been brutal if I could not rebuild the frontend.
jcschaff
changed the title
|
DO NOT MERGE - will be pushed to Netlify only |
|
Oh man, this seems fun. How are we rebuilding the prod site to do the patch? |
bilalshaikh42
approved these changes
May 31, 2023
|
Expanding the scope of the production site patches to bypass the biosimulators.org landing page (redirect to /simulators to directly display the list of simulators) - see #4706. |
This was referenced Jun 14, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What new features does this PR implement?
patch production site (v9.13.6) to link out to https://biosimulations.dev/projects for all project browsing, and to https://explorersb-test.pages.dev for a preview of the new simplified Reproducibility Portal. see Issue #4688.
(added 6/14/2023) - patch production site to bypass biosimulators.org landing page, redirecting to the list of simulators at the /simulators path. This is to avoid confusing navigation while transitioning to the new navigation scheme in the new development versions. see Issue #4706
What bugs does this PR fix?
Motivation is to highlight recent development on project browsing without touching the production site (because dev site is not yet ready to replace the production site).
How have you tested this PR?
build/tested locally (localhost:4200)
will upload build directly to Netlify for only platform app at biosimulations.org - to bypass CI/CD (broken for 9.13.6)