feat(biome_css_analyzer): implement noUnknownTypeSelector #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
Kazuhiro-Mimaki
changed the title
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/selector-type-no-unknown
branch
from
e64097d
to
1ab268f
Compare
CodSpeed Performance ReportMerging #2871 will not alter performanceComparing Summary
|
togami2864
reviewed
May 16, 2024
| version: "next", | ||
| name: "noUnknownTypeSelector", | ||
| language: "css", | ||
| recommended: false, |
There was a problem hiding this comment.
Suggested change
| recommended: false, | |
| recommended: true, | |
| sources: &[RuleSource::Stylelint("selector-type-no-unknown")], |
| .note(markup! { | ||
| "See "<Hyperlink href="https://developer.mozilla.org/en-US/docs/Web/CSS/Type_selectors">"MDN web docs"</Hyperlink>" for more details." | ||
| }).note(markup! { | ||
| "To resolve this issue, replace the unknown type selector with valid one." |
There was a problem hiding this comment.
Suggested change
| "To resolve this issue, replace the unknown type selector with valid one." | |
| "Consider replacing the unknown type selector with valid one." |
Comment on lines
+181
to
+183
| fn is_custom_element(prop: &str) -> bool { | ||
| prop.contains('-') && prop.eq(prop.to_lowercase().as_str()) | ||
| } |
There was a problem hiding this comment.
You should define this outside of the function.
Mouvedia
reviewed
May 16, 2024
There was a problem hiding this comment.
There are a lot of missing ones.
e.g. nobr, model, strike, glyphRef, etc.
check https://github.com/stylelint/stylelint/blob/main/lib/rules/selector-type-no-unknown/index.mjs#L94-L97 and https://github.com/stylelint/stylelint/blob/main/lib/reference/selectors.mjs#L47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2543
Summary
implements selector-type-no-unknown
Test Plan
Add snapshots.