Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint/noExportsInTest): avoid mistakenly identifying files with in-source testing as test files #2861

Merged
merged 2 commits into from
May 15, 2024
Merged

fix(lint/noExportsInTest): avoid mistakenly identifying files with in-source testing as test files #2861

merged 2 commits into from
May 15, 2024

Conversation

ah-yu
Copy link
Contributor

@ah-yu ah-yu commented May 15, 2024

Summary

Now we treat files containing a top-level test call as test files.

Test Plan

Added a new test

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels May 15, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 15, 2024

CodSpeed Performance Report

Merging #2861 will not alter performance

Comparing ah-yu:fix/no_exports (60b3b81) with main (d906941)

Summary

✅ 99 untouched benchmarks

@Conaclos Conaclos merged commit a9ffb7f into biomejs:main May 15, 2024
12 checks passed
@ah-yu ah-yu deleted the fix/no_exports branch May 16, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unvalley unvalley unvalley approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💅 noExportsInTest treats source code as test files when using in-source testing
3 participants
@ah-yu @unvalley @Conaclos