Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_graphql_parser): parse schema extension #2842

Merged

Conversation

vohoanglong0107
Copy link
Contributor

@vohoanglong0107 vohoanglong0107 commented May 14, 2024

Summary

Parse GraphQL schema extensions. This is a small case, as almost all parsing logic was handled by a previous PR focusing on parsing schema definition.
The schema extension syntax defined the ungrammar was needlessly complicated, this PR also simplifies the syntax.
Depends on #2841

Test Plan

All tests should pass.

@github-actions github-actions bot added the A-Tooling Area: internal tools label May 14, 2024
Copy link

codspeed-hq bot commented May 14, 2024

CodSpeed Performance Report

Merging #2842 will not alter performance

Comparing vohoanglong0107:feat-graphql-schema-extension (ce24e8d) with main (b1e7be6)

Summary

✅ 99 untouched benchmarks

@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review May 17, 2024 10:28
@ematipico ematipico merged commit 5a0ae2f into biomejs:main May 20, 2024
13 checks passed
@vohoanglong0107 vohoanglong0107 deleted the feat-graphql-schema-extension branch May 21, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants