-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(biome_js_analyzer): useJsxSortProps #2652
Draft
vohoanglong0107
wants to merge
13
commits into
biomejs:main
Choose a base branch
from
vohoanglong0107:feat-use-jsx-sort-props
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(biome_js_analyzer): useJsxSortProps #2652
vohoanglong0107
wants to merge
13
commits into
biomejs:main
from
vohoanglong0107:feat-use-jsx-sort-props
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
Area: project
A-Linter
Area: linter
L-JavaScript
Language: JavaScript and super languages
A-Diagnostic
Area: diagnostocis
labels
Apr 30, 2024
vohoanglong0107
force-pushed
the
feat-use-jsx-sort-props
branch
from
April 30, 2024 01:57
c2cf7a7
to
886494a
Compare
CodSpeed Performance ReportMerging #2652 will not alter performanceComparing Summary
|
vohoanglong0107
force-pushed
the
feat-use-jsx-sort-props
branch
from
April 30, 2024 10:19
886494a
to
0d48b11
Compare
vohoanglong0107
force-pushed
the
feat-use-jsx-sort-props
branch
from
April 30, 2024 13:41
870e6bf
to
d90a4b6
Compare
I'm not very fond of having stylistic rules inside our linter. I think this rule should be an assist. I was working on a similar rule for sorting JSON keys, and setting up the foundations for assists inside the CLI and LSP. |
Oh ok, then I will set this PR to draft for the time being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-CLI
Area: CLI
A-Diagnostic
Area: diagnostocis
A-Linter
Area: linter
A-Project
Area: project
L-JavaScript
Language: JavaScript and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement Eslint's lint rule [jsx-sort-props](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-sort-props.md]
Test Plan
All tests should pass