Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ciftools dependency and fix build/tests #974

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

JonStargaryen
Copy link
Member

@JonStargaryen JonStargaryen commented Sep 30, 2021

  • ciftools 3.0.0 (brings AlphaFold/model support to the table)
  • propose to ignore openchart dependency as it doesn't seem to be used - somebody should confirm this, I've never used any of the forester stuff
  • with that exclusion, a dependency on jackson-databind was needed
  • Acetylation_site_dataset.gz reports 403 in tests and on console, but can be downloaded manually via the browser, added this as 1 MB test resource to circumvent test issues

@JonStargaryen
Copy link
Member Author

Removed other changes, as the openchart problem is solved and Acetylation_site_dataset.gz requires more work (#975). Now only updates the ciftools version.

Copy link
Contributor

@josemduarte josemduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@josemduarte josemduarte merged commit a9e8caf into biojava:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants