Tests for StringManipulationHelper #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richarda23
commented
Jul 23, 2021
•
richarda23
commented
- identified and fixed a bug in equalsToIgnoreEndline if number of lines was different
- identified equalsToXml as not really mplemented or documented and not used
- re-implemented join() in simpler way using tests to validate unchanged behaviour and widened to accept a Collection rather than AbstractCollection
- some updated javadoc
- work towards Improve test coverage - currently 49.5% in bio-java core #944
josemduarte
approved these changes
Jul 26, 2021
aalhossary
reviewed
Jul 28, 2021
| return String.format("%1$-" + n + "s", s); | ||
| } | ||
|
|
||
| private static void validatePadding(int n) { | ||
| if (n <=0 ) { |
There was a problem hiding this comment.
Why can't the padding be == 0?
There was a problem hiding this comment.
If I set padding to 0, a java.util.MissingFormatWidthException is thrown from within String.format method when padRight is called, and a FormatFlagsConversionMismatchException when padLeft is called.
There was a problem hiding this comment.
Thank you for clarification, @richarda23. I doublechecked the Javadoc and it is inhibited from their side.
Please add your name in the @author tag.
…om/richarda23/biojava into tests-for-stringManipulationHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.