Fix CE-Symm errors #818
Merged
Fix CE-Symm errors #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might still need to do this elsewhere, or may want to fix it more thoroughly elsewhere
This fixes the NPE, but doesn't address the underlying unexpected Jmol modifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides shallow fixes for #816 and #817. By 'shallow' I mean that it fixes exceptions which were being thrown, but that there may be deeper issues. Neither bug is seems particularly serious, so I'd suggest merging this now and look for deeper issues later.
I have a test case for #817. It is kind of slow (runs CE-Symm) and needs structure-gui, so I've chosen to include it in the rcsb/symmetry project rather than in BioJava.