Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #1081 Sonar S1132 Strings literals should be placed on the left side when checking for equality #1082

Merged
merged 1 commit into from Mar 4, 2024

Conversation

jlerbsc
Copy link
Contributor

@jlerbsc jlerbsc commented Feb 26, 2024

We are aware that you may be perplexed about the ability of the Indepth solution to improve the quality of the project's code in depth without adding bugs. That's why, to reassure you, we suggest this PR.

… on the left side when checking for equality
Copy link
Contributor

@josemduarte josemduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! very nice usage of your tool. This should further improve our codesmell sonarqube scores (which now are already getting an A. Our "bugs" score is terrible on the other hand).

@josemduarte josemduarte merged commit a9542ca into biojava:master Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants