Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #1073

Merged
merged 3 commits into from Dec 4, 2023
Merged

Dependency updates #1073

merged 3 commits into from Dec 4, 2023

Conversation

sjaenick
Copy link
Contributor

@sjaenick sjaenick commented Dec 3, 2023

Dependency updates:

  • SLF4J 1.7.36
  • LOG4J 2.22.0
  • junit 5.10.1

@sjaenick
Copy link
Contributor Author

sjaenick commented Dec 4, 2023

The CI failure is unrelated to this PR, the URL at https://github.com/biojava/biojava/blob/master/biojava-core/src/test/java/org/biojava/nbio/core/util/FileDownloadUtilsTest.java#L202 seems to have changed to https://files.wwpdb.org/pub/pdb/data/structures/divided/mmCIF/45/145d.cif.gz

Since I don't know whether this is a permanent URL change, I didn't include it in the PR.

@josemduarte
Copy link
Contributor

I've just fixed that URL issue in master. Could you merge master into your branch to trigger the CI process again?

@josemduarte
Copy link
Contributor

Apologies, I was having some trouble with the github workflow setup. I've committed another fix. I think now it should work, please merge master again when you have a minute.

Copy link
Contributor

@josemduarte josemduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@josemduarte josemduarte merged commit 393a98a into biojava:master Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants