Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing genbank export new line issue #1070

Merged
merged 2 commits into from Jun 30, 2023
Merged

Conversation

josemduarte
Copy link
Contributor

Should fix #1069

@aalhossary
Copy link
Member

aalhossary commented Jun 29, 2023

Thank you @josemduarte for the fix. But I believe 2 files should be updated not only one:

  • - GenericGenbankHeaderFormat.java (L40)
  • - GenericInsdcHeaderFormat.java (L52)

Copy link
Member

@aalhossary aalhossary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a fix to GenericInsdcHeaderFormat.java#L52 as well.

@josemduarte
Copy link
Contributor Author

Good catch thanks! Now pushed

Copy link
Member

@aalhossary aalhossary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@aalhossary aalhossary merged commit d5de4b1 into biojava:master Jun 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenBank export producing spurious %n
2 participants