Additional refactoring to maintain cohesion and solid principles. #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 6, 2023 19:58
…e to maintain cohesion
…s to maintain solid principle
…n from DNASequence
josemduarte
requested changes
Apr 17, 2023
| * @throws IOException | ||
| */ | ||
| @SuppressWarnings("resource") | ||
| public static void copy(File src, File dst) throws IOException { |
There was a problem hiding this comment.
Since this PR is all about cleaning up, how about taking this opportunity to remove this method and replace it by the one provided in the java library (see TODO comment in original javadocs above)
|
I'll close for lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have refactored some code in the project.
Refactor : Rename Variable
Description : The variables didn’t explain the exact use. The fetched value was a fraction and not percentage. The Aliphatic index is converted into percentage at the end. The formulation was also broken down for readability.
Refactor : Extract Class
Description: Separated file network operations and basic read write operations to different utility class to have single principle property.
Refactor : Move method
Description : The method convertDNAtoProteinSequence in ProteinMappingTools.java was very specific to DNASequence.java class and hence the code was refactored to move the method to maintain cohesion.
Refactor : Pull up method
Description : The GeneSequence class along with other classes qualify for Broken Hierarchy Design smell. Upon further analysis, it can be seen that the getLength() method can be pulled up the hierarchy. That is what this refactoring does.
A new class DNAExtractSequence is introduced to handle this situation which extends the original DNASequence.