Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POM Cleanup: Add Maven descriptors & remove mention of Travis CI #1057

Merged
merged 3 commits into from Apr 5, 2023
Merged

POM Cleanup: Add Maven descriptors & remove mention of Travis CI #1057

merged 3 commits into from Apr 5, 2023

Conversation

JonStargaryen
Copy link
Member

  • need Maven descriptors for pom.properties files when using BioJava as dependency
  • this ensures that they are added to the artifacts

josemduarte
josemduarte approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@josemduarte josemduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

There's an unrelated test failure. It seems due to an obsoleted PDB id. I'll try to push a fix to master, so that then this can be tested.

@josemduarte
Copy link
Contributor

Ok I committed a fix: could you merge master in, so that tests run?

@josemduarte
Copy link
Contributor

Actually there were a couple more test issues (after recent remediation of some PDB entries). Now I think I fixed them all. Please try again.

@JonStargaryen
Copy link
Member Author

Thanks for updating the tests. Let's see how this goes.

@JonStargaryen JonStargaryen merged commit c573d5b into biojava:master Apr 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemduarte josemduarte josemduarte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonStargaryen @josemduarte