Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcf2maf recipe #42370

Closed
wants to merge 2 commits into from
Closed

Update vcf2maf recipe #42370

wants to merge 2 commits into from

Conversation

SusiJo
Copy link
Contributor

@SusiJo SusiJo commented Aug 7, 2023

The vcf2maf package has not been update in a while see conversation here. Users of this package released the latest changes under a cloned repo and added it to anaconda under the channel umccr. However, we would need these latest changes available in bioconda for sarek and other pipelines.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump is fine, but is it correct to come from a new fork? That suggests to me it may not be same package

@SusiJo
Copy link
Contributor Author

SusiJo commented Aug 8, 2023

@jfy133: It is a fork that was just created to make a release with the latest changes that are available in the original repo's main branch. The main developers of this package did not prepare a new release for quite a while now, even though they fixed some issues on their main branch over a year ago. It would be nice to have this available in bioconda, as we cannot use other channels in nf-core modules.

@jfy133
Copy link
Contributor

jfy133 commented Aug 8, 2023

Hm.. I see. I understand the problem but it sounds like a workaround... @bioconda/core any thoughts - are you OK with this?

@SusiJo
Copy link
Contributor Author

SusiJo commented Aug 8, 2023

Anyone who would like to stick with version 1.6.21 can do so. It would just make the latest changes of the original developers available in bioconda.

@jfy133
Copy link
Contributor

jfy133 commented Aug 8, 2023

Anyone who would like to stick with version 1.6.21 can do so. It would just make the latest changes of the original developers available in bioconda.

Sure makes sense, but if it's a fork the people owning the fork can start doing their own thing and new releases, but if the original dev on the original repo comes back and starts making releases again this could become problematic (to summarise from our discussion on slack)

@SusiJo SusiJo closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants