Close some issues #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. A separate branch for overleaf sounds like a good idea. fontawesome5 is not supported by old TexLive distribution, this is the reason why I keep fontawesome package. As you mentioned in #51, we can set adobe fonts and fontawesome optional to make this package clean. I will use separate branch for overleaf and merge your PR later this weekend. |
|
Right, a new branch for different environment is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52 and #54:
i recommend create another branch to handle overloaf temporarily. and other user use master. the problem that overloaf cannot support relative path, should be reported to developer of overloaf.
#53
not all latex engine define
\XeLaTeXby default. hologo can make this command cross all latex engine.thanks.