Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug that when choose audio but can't solve it #764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug that when choose audio but can't solve it #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/demux/flv-demuxer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,10 +485,11 @@ class FLVDemuxer {
let soundSpec = v.getUint8(0);

let soundFormat = soundSpec >>> 4;
if (soundFormat !== 2 && soundFormat !== 10) { // MP3 or AAC
this._onError(DemuxErrors.CODEC_UNSUPPORTED, 'Flv: Unsupported audio codec idx: ' + soundFormat);
return;
}
// if not support this kind of sound ,then discard it but not throw exception
// if (soundFormat !== 2 && soundFormat !== 10) { // MP3 or AAC
// this._onError(DemuxErrors.CODEC_UNSUPPORTED, 'Flv: Unsupported audio codec idx: ' + soundFormat);
// return;
// }

let soundRate = 0;
let soundRateIndex = (soundSpec & 12) >>> 2;
Expand Down Expand Up @@ -620,6 +621,9 @@ class FLVDemuxer {
let mp3Sample = {unit: data, length: data.byteLength, dts: dts, pts: dts};
track.samples.push(mp3Sample);
track.length += data.length;
} else {
// set _hasAudio && discard audio
this._hasAudio = false;
}
}

Expand Down