New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip install, basic support #597
base: master
Are you sure you want to change the base?
Conversation
@JeanPaulShapo I don't have linux machine at hand to test this.. Will try to get a clean one on AWS EC2 and play with this over the weekend. Could you split this pull request into two parts -- the one about 3rdparties removal, and the rest? Currently it is hard to review, because so many files had been deleted. The part about 3rdparty removal you may just go ahead and merge into master (as long as travis-ci is happy :)) |
@sashafrey Ok, i'll split this PR. |
@JeanPaulShapo If it takes long time than I'll just review your commits one by one... So just let me, don't waste too much time. To me it would be really great to have a clean commit (or a clean pull request) that contains everything needed for pypi package. I'll learn a lot from this myself --- I've never did it before, and it is very very nice to know how to create those pypi packages! :) |
@sashafrey So, it'll be helpful to get from this PR part related to CMake fixes and enhancement. |
@JeanPaulShapo Thanks! |
5838f90
to
7cec75e
Compare
I've got rid of "Removing 3rd-party" part. |
@JeanPaulShapo I've tried Here is my full story:
and then retry previous command. This time it recognized numpy and pandas are in place. The command started to build bigartm, which went very good! However almost at the end it failed:
|
There is also one minor change that I did to build this change on Windows: 1d9bca0 |
@sashafrey I answered to your last question in comment to PR #601. |
@JeanPaulShapo |
@JeanPaulShapo I think we should merge this PR. It enables |
@sashafrey Ideally I'd like to hear some comment from Mac OS users, that's why I ask @MelLain to test this PR. |
@JeanPaulShapo Ok, I agree. The plan is to make a new I did rebase this branch ( |
@sashafrey As for |
c403163
to
7a32227
Compare
3ba74e3
to
cf6773f
Compare
Keep this PR open, despite the fact that it is very old. This PR it is related to pip install feature - which has highest priority among all users requests to BigARTM. |
Right now we have test package on https://testpypi.python.org/pypi.
You can try to install package using typing
pip install -i https://testpypi.python.org/pypi
.However, you still must install all dependencies except git (python, cmake, boost etc.)
Right now it doesn't work on Windows.
On my machine with Fedora 22 installation works, but I'd like to receive comments from users with other Linux distributions and Mac OS'es.
Feel free to write about any problems encountered during testing.