Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with gene symbols in CCLE (and possibly other PSets) #35

Open
bhaibeka opened this issue Jan 22, 2022 · 2 comments
Open

Problem with gene symbols in CCLE (and possibly other PSets) #35

bhaibeka opened this issue Jan 22, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@bhaibeka
Copy link
Member

ss1 <- fNames(CCLE, mDataType = "mutation")
ss2 <- featureInfo(CCLE, mDataType = "mutation")[ , "Symbol",drop=TRUE]

table(is.na(ss1) == is.na(ss2))

FALSE TRUE
83 1584

These 2 vectors should be the same

@ChristopherEeles
Copy link

Hi Ben,

The Symbol column is not one of our standardized column names and therefore is not checked when creating a PharmacoSet. The fNames function instead looks at the row.names of the featureInfo data.frame, which should correspond to the standardized geneid column therein.

However, there is no geneid column in the mutation data for CCLE. Indeed, our standardized columns are missing from many of our PharmacoSet objects. This is an annotation issue, and not necessarily something we can fix in PharmacoGx.

Thus I am moving this issue to the ORCESTRA repo, where we can update the CCLE script to fix the annotation problems.

Best,
Chris

@ChristopherEeles ChristopherEeles transferred this issue from bhklab/PharmacoGx Jan 24, 2022
@ChristopherEeles
Copy link

ChristopherEeles commented Jan 24, 2022

To clarify, there are a number of NA values in featureInfo(CCLE, "mutation")$Symbol which are not present in the row.names of that object. Additionally, the standardized geneid column is absent from the SummarizedExperiment, which prevents this issue from being caught during PharmacoSet creation.

@ChristopherEeles ChristopherEeles added the bug Something isn't working label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants