Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight code examples and put single quotes only #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
55 changes: 31 additions & 24 deletions README.md
Expand Up @@ -6,38 +6,45 @@ See demo here: http://bgrins.github.com/nativesortable/

## Usage

var list = document.getElementById("list");
nativesortable(list, {
change: function(parent, elem) {
// ...
},
childClass: "sortable-child",
draggingClass: "sortable-dragging",
overClass: "sortable-over"
});
```js
var list = document.getElementById("list");
nativesortable(list, {
change: function(parent, elem) {
// ...
},
childClass: "sortable-child",
draggingClass: "sortable-dragging",
overClass: "sortable-over"
});
```

## Package Management

bower install nativesortable
- or -
npm install nativesortable
```
bower install nativesortable
- or -
npm install nativesortable
```

## Extra CSS

I would also recommend adding the following CSS:

[draggable] {
-moz-user-select: none;
-khtml-user-select: none;
-webkit-user-select: none;
user-select: none;
}
[draggable] * {
-moz-user-drag: none;
-khtml-user-drag: none;
-webkit-user-drag: none;
user-drag: none;
}
```css
[draggable] {
-moz-user-select: none;
-khtml-user-select: none;
-webkit-user-select: none;
user-select: none;
}

[draggable] * {
-moz-user-drag: none;
-khtml-user-drag: none;
-webkit-user-drag: none;
user-drag: none;
}
```

This makes sure that

Expand Down
30 changes: 15 additions & 15 deletions nativesortable.js
Expand Up @@ -5,7 +5,7 @@
* http://www.html5rocks.com/en/tutorials/dnd/basics/#toc-examples
*
* @example
* var list = document.getElementByID("list");
* var list = document.getElementByID('list');
* nativesortable(list, { change: onchange });
*
* @author Brian Grinstead
Expand All @@ -29,7 +29,7 @@
})();

function hasClassName(el, name) {
return new RegExp("(?:^|\\s+)" + name + "(?:\\s+|$)").test(el.className);
return new RegExp('(?:^|\\s+)' + name + '(?:\\s+|$)').test(el.className);
}

function addClassName (el, name) {
Expand All @@ -41,7 +41,7 @@
function removeClassName(el, name) {
if (hasClassName(el, name)) {
var c = el.className;
el.className = c.replace(new RegExp("(?:^|\\s+)" + name + "(?:\\s+|$)", "g"), " ").replace(/^\s\s*/, '').replace(/\s\s*$/, '');
el.className = c.replace(new RegExp('(?:^|\\s+)' + name + '(?:\\s+|$)', 'g'), ' ').replace(/^\s\s*/, '').replace(/\s\s*$/, '');
}
}

Expand Down Expand Up @@ -101,13 +101,13 @@

function dragenterData(element, val) {
if (arguments.length == 1) {
return parseInt(element.getAttribute("data-child-dragenter"), 10) || 0;
return parseInt(element.getAttribute('data-child-dragenter'), 10) || 0;
}
else if (!val) {
element.removeAttribute("data-child-dragenter");
element.removeAttribute('data-child-dragenter');
}
else {
element.setAttribute("data-child-dragenter", Math.max(0, val));
element.setAttribute('data-child-dragenter', Math.max(0, val));
}
}

Expand All @@ -121,9 +121,9 @@
var start = opts.start || function() { };
var change = opts.change || function() { };

var CHILD_CLASS = opts.childClass || "sortable-child";
var DRAGGING_CLASS = opts.draggingClass || "sortable-dragging";
var OVER_CLASS = opts.overClass || "sortable-over";
var CHILD_CLASS = opts.childClass || 'sortable-child';
var DRAGGING_CLASS = opts.draggingClass || 'sortable-dragging';
var OVER_CLASS = opts.overClass || 'sortable-over';

var currentlyDraggingElement = null;
var currentlyDraggingTarget = null;
Expand All @@ -135,7 +135,7 @@

if (e.dataTransfer) {
e.dataTransfer.effectAllowed = 'moving';
e.dataTransfer.setData('Text', "*"); // Need to set to something or else drag doesn't start
e.dataTransfer.setData('Text', '*'); // Need to set to something or else drag doesn't start
}

currentlyDraggingElement = this;
Expand Down Expand Up @@ -284,7 +284,7 @@
function addFakeDragHandlers() {
if (!supportsDragAndDrop) {
if (supportsTouch) {
element.addEventListener("touchmove", handleTouchMove, false);
element.addEventListener('touchmove', handleTouchMove, false);
}
else {
element.addEventListener('mouseover', handleDragEnter, false);
Expand All @@ -293,7 +293,7 @@

element.addEventListener(supportsTouch ? 'touchend' : 'mouseup', handleDrop, false);
document.addEventListener(supportsTouch ? 'touchend' : 'mouseup', handleDragEnd, false);
document.addEventListener("selectstart", prevent, false);
document.addEventListener('selectstart', prevent, false);

}

Expand All @@ -302,7 +302,7 @@
function removeFakeDragHandlers() {
if (!supportsDragAndDrop) {
if (supportsTouch) {
element.removeEventListener("touchmove", handleTouchMove, false);
element.removeEventListener('touchmove', handleTouchMove, false);
}
else {
element.removeEventListener('mouseover', handleDragEnter, false);
Expand All @@ -311,7 +311,7 @@

element.removeEventListener(supportsTouch ? 'touchend' : 'mouseup', handleDrop, false);
document.removeEventListener(supportsTouch ? 'touchend' : 'mouseup', handleDragEnd, false);
document.removeEventListener("selectstart", prevent, false);
document.removeEventListener('selectstart', prevent, false);
}
}

Expand All @@ -335,7 +335,7 @@

[].forEach.call(element.childNodes, function(el) {
if (el.nodeType === 1) {
el.setAttribute("draggable", "true");
el.setAttribute('draggable', 'true');
}
});

Expand Down