Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite meson.build #77

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Rewrite meson.build #77

wants to merge 1 commit into from

Conversation

wrvsrx
Copy link

@wrvsrx wrvsrx commented Aug 12, 2023

This rewriting make three changes:

  1. This project compiled by meson used to produce an empty .a file.
    This should not happen since lyra is pure header library.
  2. Now meson can correctly install these header files.
  3. Now lyra.pc file is automatically created by meson.

Copy link
Member

@grafikrobot grafikrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The meson build file is generated from the regular B2 build files: https://github.com/bfgroup/Lyra/blob/develop/data/build.jam
  2. Why does this need to be two files?

@wrvsrx
Copy link
Author

wrvsrx commented Aug 18, 2023

  1. Sorry for my negligence, I'll change this PR to use the B2 build file for generating meson.build.
  2. I use two meson.build files to use meson's preseve_path feature, since it can simplify some logics. I can use only single file if you don't want that.

include/meson.build Outdated Show resolved Hide resolved
@wrvsrx
Copy link
Author

wrvsrx commented Oct 23, 2023

I make changes to data/build.jam and regenerate meson.build.

@wrvsrx
Copy link
Author

wrvsrx commented Oct 23, 2023

It seems the mingw-related errors in the test have nothing to do with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants