-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make render phases render world resources instead of components. #13277
Merged
alice-i-cecile
merged 8 commits into
bevyengine:main
from
pcwalton:decomponentize-render-phases
May 21, 2024
Merged
Make render phases render world resources instead of components. #13277
alice-i-cecile
merged 8 commits into
bevyengine:main
from
pcwalton:decomponentize-render-phases
May 21, 2024
Commits on May 7, 2024
-
Make render phases render world resources instead of components.
This commit makes us stop using the render world ECS for `BinnedRenderPhase` and `SortedRenderPhase` and instead use resources with `EntityHashMap`s inside. There are three reasons to do this: 1. We can use `clear()` to clear out the render phase collections instead of recreating the components from scratch, allowing us to reuse allocations. 2. This is a prerequisite for retained bins, because components can't be retained from frame to frame in the render world, but resources can. 3. We want to move away from storing anything in components in the render world ECS, and this is a step in that direction. This patch results in a small performance benefit, due to point (1) above.
Configuration menu - View commit details
-
Copy full SHA for abeb02b - Browse repository at this point
Copy the full SHA abeb02bView commit details
Commits on May 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 98b00ee - Browse repository at this point
Copy the full SHA 98b00eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5be1b1 - Browse repository at this point
Copy the full SHA d5be1b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a1e958 - Browse repository at this point
Copy the full SHA 0a1e958View commit details
Commits on May 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 844f792 - Browse repository at this point
Copy the full SHA 844f792View commit details -
Configuration menu - View commit details
-
Copy full SHA for 018b442 - Browse repository at this point
Copy the full SHA 018b442View commit details -
Skip queuing prepass meshes if no prepass phase is scheduled.
This fixes the problem that led to bevyengine#13402. I'm not sure if this had any negative consequences, but it didn't replicate the prior behavior with the `Or` query filter, so I changed it to match.
Configuration menu - View commit details
-
Copy full SHA for 5caff40 - Browse repository at this point
Copy the full SHA 5caff40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55f4d16 - Browse repository at this point
Copy the full SHA 55f4d16View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.