This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Fix Benchmark#toString() of error (again) #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Benchmark#toString()` incorrectly calls `join(error)` if `!_.isError(Error)`, which is always true because `Error` the function is not an instance of `Error`. When `error` is an instance of `Error` this results in an empty string, as discussed in bestiejs#122. Fix the check to be `!_.isError(error)`. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark#toString()incorrectly callsjoin(error)if!_.isError(Error), which is always true becauseErrorthe function is not an instance ofError. Whenerroris an instance ofErrorthis results in an empty string, as discussed in #122.Fix the check to be
!_.isError(error).I'm a bit confused about how this happened. The issue appears to have occurred in b4bd181, which was ostensibly authored by me. However 9728173, which was the actually authored by me and merged in #122 does not have this error. Perhaps a post-merge fix amended the commit and didn't change the author?
Thanks for considering,
Kevin