Reset cursor on page change or category change #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @f01c33 and thanks for the PR! I think this makes sense for category change, but for the page change I like the behavior of having the cursor the same place. Would you be able to update the PR for this? |
|
Sure! |
|
Changes done @bensadeh, it wasn't working correctly inside the: if m.categoryHasStories(nextCat){So i changed it to be above, and now it works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, so this is mainly a UX decision, of course, but i think the cursor should reset to 0 on page change or category change, it just makes more sense having a nice refresh on page changes, feel free to close if it does not make much sense to you :)