[TASK] Cleanup esm migration #1422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnf
commented
Aug 29, 2023
bnf
commented
- Require at least TYPO3 v12.4.5 as a bug was preent until v12.4.4 https://review.typo3.org/c/Packages/TYPO3.CMS/+/80174
- Remove jquery requirement
- Use instanciated stage module (like the core does as well)
- Use array unfolding to make generic args array elements readable without requiring doc comments
- Avoid unneeded doc comments
* Require at least TYPO3 v12.4.5 as a bug was preent until v12.4.4 https://review.typo3.org/c/Packages/TYPO3.CMS/+/80174 * Remove jquery requirement * Use instanciated stage module (like the core does as well) * Use array unfolding to make generic args array elements readable without requiring doc comments * Avoid unneeded doc comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.