Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1309 footer language switch #1346

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

schmigotzki
Copy link
Contributor

Pull Request

Related Issues

Prerequisites

  • Changes have been tested on TYPO3 v12.4 LTS
  • Changes have been tested on PHP 8.1
  • CSS has been rebuilt (only if there are SCSS changes cd Build; npm ci; npm run build)

Description

Problem:
If a language switch is offered, it must lead to an actual page where document language and content language both meet user expectation. A lang switch "German" must lead to a page in German with <html lang="de">

Solution:

  • language menu will not be shown if there is only one language (the current one)
  • language menu item will not be a link if we are already on that page
  • only available languages will be shown
  • removed title attribute because the screen reader already reads the link text

Steps to Validate

  1. You need an installation with more than one defined language
  2. A page without any other translation will not show the language menu in the footer
  3. A page with a translation will show all available languages in the footer menu
  4. The current page (language) will not be a link in the footer menu

@eliashaeussler
Copy link
Contributor

@alexakressmann This PR can now be reviewed on https://bitv-v12.live.typo3.cps.321.works/.

@benjaminkott benjaminkott force-pushed the feature/1309-footer-language-switch branch from 4e64388 to 7d3d7d6 Compare June 15, 2023 05:24
@benjaminkott benjaminkott force-pushed the feature/1309-footer-language-switch branch from 7d3d7d6 to 354581a Compare June 15, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y Code Sprint Berlin: Success Criterion 9.3.1.1. - remove language switch from footer
2 participants