Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: #1075 Image multiplier loop in ImageVariantsUtility.php #1159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX: #1075 Image multiplier loop in ImageVariantsUtility.php #1159

wants to merge 1 commit into from

Conversation

jonasesr
Copy link

Loop over variants and apply the right multiplier instead of looping over variants.

Pull Request

Related Issues

Prerequisites

  • Changes have been tested on TYPO3 v9.5 LTS
  • Changes have been tested on TYPO3 v10.4 LTS
  • Changes have been tested on TYPO3 v10.4 LTS
  • Changes have been tested on TYPO3 dev-master
  • Changes have been tested on PHP 7.2.x
  • Changes have been tested on PHP 7.3.x
  • Changes have been tested on PHP 7.4.x
  • Changes have been checked for CGL compliance php-cs-fixer fix

Description

[Description of changes proposed in this pull request]

Steps to Validate

  1. Create carousel content element
  2. Watch processed files

@jonasesr
FIX: benjaminkott#1075 Image multiplier loop in ImageVariantsUtility.php
5e6dbd4 
Loop over variants and apply the right multiplier instead of looping over variants.
@gilbertsoft gilbertsoft mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activation of Responsive Images does not apply to carousel in 12.0.1
1 participant
@jonasesr