FIX benchmark_utils pickling #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
May 16, 2024
|
Let's just wait for confirmation that this fixes the issue of @antoinecollas :) |
|
It works! Thanks a lot Thomas 🙏🏻 |
|
@agramfort feel free to merge once it is green 😉 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
- Coverage 49.51% 49.42% -0.10%
==========================================
Files 45 45
Lines 3009 3019 +10
Branches 570 572 +2
==========================================
+ Hits 1490 1492 +2
- Misses 1376 1383 +7
- Partials 143 144 +1 |
|
thx @tomMoral ! |
tomMoral
added a commit
to tomMoral/benchopt
that referenced
this pull request
May 17, 2024
* FIX benchmark_utils pickling * TST add some non-regression test * DOC add what's new entry+explain test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #712 which was merged a bit quickly.
This should fix the issue in scikit-adaptation/skada-bench#60 with missing
benchmark_utilsmodule.