-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameters as columns in result file #703
base: main
Are you sure you want to change the base?
Add parameters as columns in result file #703
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
==========================================
- Coverage 54.30% 54.27% -0.04%
==========================================
Files 45 45
Lines 2994 3007 +13
Branches 560 565 +5
==========================================
+ Hits 1626 1632 +6
- Misses 1243 1249 +6
- Partials 125 126 +1 |
if key in slv_parameters: | ||
slv_parameters["solver_" + key] = slv_parameters.pop(key) | ||
if key in ds_parameters: | ||
ds_parameters["dataset_" + key] = ds_parameters.pop(key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking back after our discussion, this solution is not working :(
If you have two solvers: solver1 with param a
and solver2 with no param, and a dataset with param a
, you will end up with 3 columns for param a
, depending on the combination.
I think the best course of action is to use prefix all the time. It is a little bit ugly but it is robust and don't require too much dev compared to introspecting everything.
Checks before merging PR