Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "paths" key in available config keys #701

Merged
merged 22 commits into from
Jun 4, 2024

Conversation

Melvin-klein
Copy link
Member

Allow the key paths in benchmark config.

Copy link
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, this looks good but we should add documentation and test for it.

@tomMoral
Copy link
Member

This would close #627

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (9afa0a4) to head (bcfaf10).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
+ Coverage   80.90%   81.04%   +0.13%     
==========================================
  Files          45       45              
  Lines        3058     3075      +17     
==========================================
+ Hits         2474     2492      +18     
+ Misses        584      583       -1     

benchopt/tests/test_benchmark_features.py Outdated Show resolved Hide resolved
benchopt/tests/test_benchmark_features.py Outdated Show resolved Hide resolved
benchopt/config.py Outdated Show resolved Hide resolved
Copy link
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomMoral tomMoral merged commit 3b18736 into benchopt:main Jun 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants