DOC update for the run_once sampling strategy
#700
Merged
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathurinm
reviewed
Jun 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
=======================================
Coverage 81.27% 81.27%
=======================================
Files 45 45
Lines 3108 3108
=======================================
Hits 2526 2526
Misses 582 582 |
tomMoral
reviewed
Jun 5, 2024
doc/user_guide/advanced.rst
Outdated
| @@ -148,7 +148,7 @@ implemented in the ``Solver.warm_up`` method, which is empty by default and | |||
| called after the `set_objective` method. For solvers with | |||
| ``sampling_strategy`` in ``{'tolerance', 'iteration'}``, simply calling the | |||
| ``Solver.run`` with a simple enough value is usually enough. For solvers with | |||
| ``sampling_strategy`` set to ``'callback'``, it is possible to call | |||
| ``sampling_strategy`` in ``{'callback', 'run_once'}``, it is possible to call | |||
There was a problem hiding this comment.
Not sure that this is really the right message?
There was a problem hiding this comment.
Why wouldn't that be the case?
tomMoral
reviewed
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation for the case where
sampling_strategyis set torun_once