-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MATLAB solver #612
base: main
Are you sure you want to change the base?
Conversation
cool ! any chance to have such a runner? |
Creating a self hosting runner is pretty easy 1, choosing who is going to pay for it and the associated MATLAB license is harder (short answer: not me) . Then its a matter of switching the CI to the self hosted runner in the repo setting. For now I have disable the test running the solver 'matlab-pgd' in the dummy benchmark. Footnotes |
It seems to me that |
Let me try, but the issue I mentioned in the opening post does not really give hope 😕 |
It seems to crash big time indeed ^^ |
So the CI should now pass, as the MATLAB solver is not run if we can't find a matlab installation. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #612 +/- ##
==========================================
+ Coverage 54.91% 55.05% +0.13%
==========================================
Files 44 45 +1
Lines 2846 2870 +24
Branches 523 528 +5
==========================================
+ Hits 1563 1580 +17
- Misses 1165 1173 +8
+ Partials 118 117 -1 |
This add support for MATLAB-based solver, and is based on the matlab-engine package.
I also provide a dummy example of PGD solver using MATLAB.
As mentioned in #606 , the CI is the main issue here. Running matlab from the engine in CI is not supported by Mathworks
1 and would required to have a self hosted runner with a MATLAB license.
This make the CI fail for now.
Footnotes
https://github.com/matlab-actions/setup-matlab/issues/22 ↩