Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MATLAB solver #612

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

paquiteau
Copy link
Contributor

@paquiteau paquiteau commented Jul 10, 2023

This add support for MATLAB-based solver, and is based on the matlab-engine package.

I also provide a dummy example of PGD solver using MATLAB.

As mentioned in #606 , the CI is the main issue here. Running matlab from the engine in CI is not supported by Mathworks
1 and would required to have a self hosted runner with a MATLAB license.

This make the CI fail for now.

Footnotes

  1. https://github.com/matlab-actions/setup-matlab/issues/22

@paquiteau paquiteau changed the title Add support for MATLAB solver [DRAFT] Add support for MATLAB solver Jul 10, 2023
@paquiteau paquiteau changed the title [DRAFT] Add support for MATLAB solver Add support for MATLAB solver Jul 10, 2023
@agramfort
Copy link
Collaborator

cool ! any chance to have such a runner?

@paquiteau
Copy link
Contributor Author

paquiteau commented Jul 10, 2023

Creating a self hosting runner is pretty easy 1, choosing who is going to pay for it and the associated MATLAB license is harder (short answer: not me) . Then its a matter of switching the CI to the self hosted runner in the repo setting.

For now I have disable the test running the solver 'matlab-pgd' in the dummy benchmark.

Footnotes

  1. https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners

@tomMoral
Copy link
Member

It seems to me that github-action allows to use matlab for testing purposes without license on public repo no?
https://github.com/matlab-actions#setup-matlab

@paquiteau
Copy link
Contributor Author

Let me try, but the issue I mentioned in the opening post does not really give hope 😕

@tomMoral
Copy link
Member

tomMoral commented Jul 10, 2023

It seems to crash big time indeed ^^

@paquiteau
Copy link
Contributor Author

So the CI should now pass, as the MATLAB solver is not run if we can't find a matlab installation.
If a dedicated runner can be set up that would be ideal but that's the best I can do for now.

@codecov-commenter
Copy link

Codecov Report

Merging #612 (82b04c7) into main (c1f1e60) will increase coverage by 0.13%.
The diff coverage is 46.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   54.91%   55.05%   +0.13%     
==========================================
  Files          44       45       +1     
  Lines        2846     2870      +24     
  Branches      523      528       +5     
==========================================
+ Hits         1563     1580      +17     
- Misses       1165     1173       +8     
+ Partials      118      117       -1     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants