-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a tag field for BaseSolver #586
base: main
Are you sure you want to change the base?
Conversation
Here is the preview of the visualization feature, and the benchmark repository to reproduce it. Also, how should we handle visualization conflicts between tags and solvers? |
Excellent ! Thank you. In my opinion,
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
===========================================
- Coverage 80.80% 54.60% -26.20%
===========================================
Files 45 44 -1
Lines 3027 2864 -163
Branches 0 529 +529
===========================================
- Hits 2446 1564 -882
- Misses 581 1181 +600
- Partials 0 119 +119 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice start, would be interesting to finish this one during the sprint?
tags = ['proximal_coordinate_descent', 'python']
)(issue #571)