Throw UnsupportedOperationException for unsupported ForkChannel.connect() methods #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No longer needed as flush has been removed. |
|
Got it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForkChannel.connect(String cluster_name, boolean useFlushIfPresent)andForkChannel.connect(String cluster_name, Address target, long timeout, boolean useFlushIfPresent)are not overridden in ForkChannel and will call subclass JChannel. This change instead makes them throw UnsupportedOperationException.This change also corrects the javadoc that a closed ForkChannel can be reused (it cannot).