Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to unittest.mock and do not run tests on python 2 #1031

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jblanckelkoo
Copy link

@jblanckelkoo jblanckelkoo commented May 19, 2022

Replaces #1029

@bittner
Copy link
Member

bittner commented May 19, 2022

I think, as long as Python 2.7 is supported tests should run for it. For what I can see there are two options:

  • Either release the current state as "the last version supporting 2.7" and drop Python 2.7 support completely after the release (hence this or a similar PR).
  • Or add try: ... except: ... constructs to the code base to make our code work for both the independent mock package and the Python library's unittest.mock.

Personally, I'd rather go for the first option. But how realistic it is that this will actually happen, you have to tell, @jenisys. It would be a long overdue thing to do, I feel, and would make a lot of people happy (aka restore their trust in this project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants