This repository has been archived by the owner on Aug 20, 2019. It is now read-only.
Remove duplicated vagrant default config #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxyc
reviewed
Apr 25, 2017
Vagrantfile
Outdated
| @@ -12,25 +12,13 @@ config_dir = ENV['BEET_CONFIG_DIR'] || "#{beet_root}/.beetbox" | |||
| project_config = "#{config_dir}/config.yml" | |||
| local_config = "#{config_dir}/local.config.yml" | |||
| composer_json = "#{beet_root}/composer.json" | |||
| vendor_dir = %x(composer config vendor-dir).strip | |||
|
Linking geerlingguy/drupal-vm#1256 |
AlexSkrypnyk
reviewed
May 1, 2017
| @@ -11,7 +11,6 @@ installed_extras_apparmor: yes | |||
| installed_extras_avahi: yes | |||
| installed_extras_composer: yes | |||
| installed_extras_drush: yes | |||
| installed_extras_drupal_console: yes | |||
There was a problem hiding this comment.
@thom8 what is the reason to remove console?
There was a problem hiding this comment.
It's now recommended to add as a project dependency + geerlingguy/drupal-vm#1339 (comment)
AlexSkrypnyk
approved these changes
May 1, 2017
thom8
force-pushed
the
vagrant_default
branch
2 times, most recently
from
de48abc
to
643614e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pull default vars directly from project directory.