Replace py3_path, bytestring_path, cpu_count implementations with builtins
#5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`os.fsdecode` has only been available since Python 3.2.
os.cpu_count has only been available since Python 3.4
Same `os.fsdecode`, this has only been available since Python 3.2 which was after this code was written.
|
Tip: consider using |
|
The changelog update workflow is failing for some reason
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These functions had been written before builtins achieving the same have been made available (in
Python 3.2 and 3.4).
Now that they are available though, this PR updates the codebase to use builtin implementations rather than the custom ones.