Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension issue in convert plugin when exporting a playlist #5203

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pierreay
Copy link

Description

Fix extension substitution inside path of the exported playlist.

Before this, the exported playlist contained relative paths pointing to the
converted files BUT the extension were not substituted comparing to before and
the after the conversion. Therefore, running the playlist will fail for files
which have been converted and where extension have changed.

Example:

  1. Convert /path/to/library/artist.flac to /path/to/converted/artist.mp3 using the -m playlist.m3u command-line flag.
  2. Open the generated playlist, and find the incorrect path /path/to/converted/artist.flac inside.

To Do

  • Documentation
  • Changelog
  • Tests

Before this, the exported playlist contained relative paths pointing to the
converted files BUT the extension were not substituted comparing to before and
the after the conversion. Therefore, running the playlist will fail for files
which have been converted and where extension have changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant