[latte] Fix BrokerClient topic handling #11
Merged
+161
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the previous implementation where the BrokerClient would deregister a topic as soon as a specific key didn't have any listeners, ignoring the fact that other keys might be listening on the same topic. In tea this caused errors, because our clients then tried to access topics that were errorneously removed. This PR fixes the logic to only deregister a topic when there actually are no listeners for any keys. It also moves this handling of keys and topics into the
TopicMetadataclass so that theBrokerClientdoesn't have to deal with it anymore.Additionally, a bug/error caused by recursive BrokerClient destruction has been fixed, and some additional logging added. The Log4j config has been adjusted to actually allow those logs to be processed; previously, Log4j would use its own shutdown hook and stop logging anything once shutdown is initiated, meaning we didn't see the aforementioned errors and logs during destruction.