-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use redis 3 for tls #451
use redis 3 for tls #451
Conversation
Is there any hope of this PR being accepted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@chrislim @b-jam I'm accepting this PR over here: compwright#5 |
Thanks @compwright . This project is looking for a new maintainer if you're interested: #528 |
@bradvogel this is ready to go, priority |
@bradvogel CI checks seem to be stuck, and it won't let me merge until those pass. We will need to drop support for Node 4-10, since dependencies used in this project no longer support those versions. I seem to be missing some project permissions to resolve this, can you help? |
@compwright I just upgraded you to the "Maintain" role. Are you able to fix now? |
@bradvogel no. I either need a way to re-run the checks on this branch (I may be missing something here), or to override the merge restriction. |
@compwright Here's what I see as an admin. It looks like CI is stuck? I have no way to re-run it either. What level of access do you need to fix CI? |
@bradvogel I would need repo admin to manage branch protection rules. I don't have the override checkbox you see there. https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization |
Resubmitted to re-trigger CI checks #546 |
As previously discussed in #257
In the interest of security, to utilisize
rediss
over TLS. I noticed dependabot was also complaining about redis too.It seemed like no progress is being made towards bee-queue 2.0 or using IOredis so this is necessary.
Node 4 support needs to be dropped as a result, but that was EOL in 2018
(Node 8 is also EOL as is 10) https://endoflife.software/programming-languages/server-side-scripting/nodejs