Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip duplicates when exploring entries on import extract #1663

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zenitraM
Copy link

Hi! I use the Importer UI with some API-driven importers, for which the downloaded files are really only config files yet they read the full history from the origin bank APIs (like https://tariochbctools.readthedocs.io/en/latest/importers.html#nordigen).

Those output a big chunk of past entries, sometimes from multiple banks and not necessarily in chronological order. And, most of the time, a big percentage of those entries will be duplicated - in some importers the de-duplication is done by the importer against the bank's entry ID so I'm almost completely sure they are not false positives.

So I'm only interested (most of the time) on checking the non-duplicate entries, however in some cases (like combining multiple banks into a same importer, or reconciling a long tail of history) they will be 4-5 new/non-duplicate entries out of a list of >400 entries, in the middle of the list.

Browsing them and finding them with the next/back buttons is a bit awkward, so to make this easier, I've added a checkbox that will only make the prev/next buttons in the Extract window move only across the non-duplicate entries, which is enabled by default - which I think may be a more desired standard behavior?

It looks like this on the UI:

image
The checkbox make the buttons go to the next and previous non-duplicate items - and if there's none left, they will just go to the first/last entry (to finalize the import, in the latter case).

I found this quite useful for my workflow but it may not fit everyone's usage or the project's alikes - happy to address any feedback or tweaks. 馃槉

@yagebu
Copy link
Member

yagebu commented Sep 6, 2023

Hi, thanks for the PR!

It might be confusing to have both "ignore duplicate" and "skip duplicates", those sound quite similar to me. Would maybe having this behaviour triggered when Ctrl-Clicking on the button also be an option instead of having the checkbox?

@zenitraM zenitraM force-pushed the skip-duplicates-on-import-extract branch from a858e21 to f612de1 Compare September 8, 2023 17:24
@zenitraM
Copy link
Author

zenitraM commented Sep 8, 2023

Agree, I found it a bit confusing too but couldn't think how to express it better.
What about something like this? With > used for the next entry, >> to jump to the next non-duplicate.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants