fix unused variable warning #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
…softirq" This reverts commit 2d89891.
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
This reverts commit 00f0ea7. Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
… on bootup Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
#https://lkml.org/lkml/2016/6/14/967 Pwm channels don't send uevents when exported, this change adds the channels to a pwm class and set their device type to pwm_channel so uevents are sent. To do this properly, the device names need to change to uniquely identify a channel. This change is from pwmN to pwm-(chip->base):N Signed-off-by: David Hsu <davidhsu@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
This reverts commit 956b200. Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
ADC channel 0 photodiode detects both infrared + visible light, but ADC channel 1 just detects infrared. However, the latter is a bit more sensitive in that range so complete darkness or low light causes a error condition in which the chan0 - chan1 is negative that results in a -EAGAIN. This patch changes the resulting lux1_input sysfs attribute message from "Resource temporarily unavailable" to a user-grokable lux value of 0. Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
…oves to v4.14.x base Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
When disabling an omap device (not when removing the driver), the device is removed but the hwmod's linger. Fix the resource leak and the crash when calling omap_device_idle() after the device's omap data have been removed. Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Having an omap serial device without a serial aliases doesn't work. For now fallback to using the hwmod instance. Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
When using DT the driver devm_kalloc's platform data and assigns them directly to the pdev->dev.platform variable. This is wrong since device de-registration expects the data to be kmalloc'ed instead, resulting in a crash. Fix by copying the platform data to a kmalloc buffer. Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
We are going to need the overlays to appear on sysfs with runtime global properties (like master enable) so turn them into kobjects. They have to be in sysfs so that people can have information about the overlays applied in the system, i.e. where their targets are and whether removal is possible. In a future more attributes can be added in a backwards compatible manner. Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
A throw once master enable switch to protect against any further overlay applications if the administrator desires so. A kernel command line option is provided as well. Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Documentation ABI entry for overlays sysfs entries. Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
RobertCNelson
force-pushed
the
4.14
branch
2 times, most recently
from
be56edc
to
6ad28ee
Compare
RobertCNelson
force-pushed
the
4.14
branch
2 times, most recently
from
0e6b291
to
f7ed29a
Compare
RobertCNelson
force-pushed
the
4.14
branch
3 times, most recently
from
334fb02
to
898fcce
Compare
RobertCNelson
force-pushed
the
4.14
branch
3 times, most recently
from
a4b9f96
to
b532292
Compare
RobertCNelson
force-pushed
the
4.14
branch
2 times, most recently
from
28cf336
to
fd90218
Compare
RobertCNelson
force-pushed
the
4.14
branch
2 times, most recently
from
cf8aa20
to
6ab314d
Compare
RobertCNelson
force-pushed
the
4.14
branch
2 times, most recently
from
bf0870f
to
36b21ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if the 4.19 tree has this actually dropped, but the variable removal wasn't complete for 4.14 (i didn't go backwards in time to find the 'first' place).