Zero contents before freeing, do not leak keys #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa01567. Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
This reverts commit 4dc7dca.
This reverts commit 9193168.
…cdc_unload()" This reverts commit 299676e.
…eanup()" This reverts commit 7680684.
This reverts commit 0892292.
…ock rate" This reverts commit 10ca4f3.
This reverts commit 984edb0.
This reverts commit 9f6aed1.
…struction" This reverts commit e34e57a.
This reverts commit dccd567.
This reverts commit d8ff0c6.
This reverts commit e462acc.
…ate_fb()" This reverts commit bcf7ab1.
…alls" This reverts commit 76fb2b4.
This reverts commit 6db644b.
This reverts commit 91df99d.
… stop()" This reverts commit 6b49c65.
…uncs" This reverts commit f63f2c8.
This reverts commit 8692835.
…ncs" This reverts commit a4e7a1e.
This reverts commit 1757f7e.
This reverts commit db464d1.
This reverts commit ebbd1c9.
This reverts commit 83822fb.
This reverts commit 7262f5d.
This reverts commit e8cb1f8.
This reverts commit 65eab9a.
This reverts commit e6cbc04.
This reverts commit 8ff2aeb.
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
https://groups.google.com/forum/#!topic/beagleboard/s1RCR0FJOfo Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Reduce max_segs to 64, a value that allows allocation of an entire EDMA descriptor list within a single page - EDMA descriptors are 40 bytes and the header is much larger. This avoids doing a higher order GFP_ATOMIC allocation in edma_prep_slave_sg when setting up a transfer which can potentially fail due to fragmentation under heavy I/O load. The current value of 1024 is unusually high in comparison to other mmc host drivers which mostly use values of between 1 and 256. The EDMA driver at present splits lists above 20 segments in any case so reducing the size of lists we pass to it shouldn't add much overhead. rcn-ee: add use_adma option: https://www.spinics.net/lists/linux-omap/msg137942.html Signed-off-by: Will Newton <willn@resin.io> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
…e directly Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
The newly added dtc warning to check DT unit-address without reg property and vice-versa generates lots of warnings. Turn off the check unless building with W=1 or W=2. Signed-off-by: Rob Herring <robh@kernel.org> Cc: Michal Marek <mmarek@suse.com> Cc: linux-kbuild@vger.kernel.org
Recent versions of libfdt add a dependency on strnlen. Copy the implementation in lib/string.c here, so we can update libfdt. Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
4.4 TI Delta: RobertCNelson/ti-linux-kernel@f89a69b...4a9c4fe Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
crow-misia
pushed a commit
to crow-misia/linux
that referenced
this pull request
Mar 29, 2019
…_ctx commit 227ad6d upstream. Delay the drm_modeset_acquire_init() until after we check for an allocation failure so that we can return immediately upon error without having to unwind. WARNING: lock held when returning to user space! 4.20.0+ beagleboard#174 Not tainted ------------------------------------------------ syz-executor556/8153 is leaving the kernel with locks still held! 1 lock held by syz-executor556/8153: #0: 000000005100c85c (crtc_ww_class_acquire){+.+.}, at: set_property_atomic+0xb3/0x330 drivers/gpu/drm/drm_mode_object.c:462 Reported-by: syzbot+6ea337c427f5083ebdf2@syzkaller.appspotmail.com Fixes: 144a799 ("drm: Handle properties in the core for atomic drivers") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@linux.ie> Cc: <stable@vger.kernel.org> # v4.14+ Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20181230122842.21917-1-chris@chris-wilson.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer should be zeroed before freeing. Cryptographic info will be leaked if contents not zeroed