Separated TextBox Decorations #987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separates the decoration of TextBox into: 1- focusedDecoration 2- unFocusedDecoration 3- focusedForegroundDecoration 4- unFocusedForegroundDecoration
|
Hello! Thank you for this pull request. I like the idea of having a different decoration for different states, but the way you proposed is a bit limiting. It'd be nice to have it like buttons do: with a TextBox(
decoration: ButtonState.all(BoxDecoration(
...
)),
) |
|
do you mean that you want me to replace these:
with |
|
yes! what do you think? |
|
OK, It is a pretty idea. I will do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates TextBox Decorations into:
1- focusedDecoration
2- unFocusedDecoration
3- focusedForegroundDecoration
4- unFocusedForegroundDecoration
Bocuse the color of the TextBox ForegroundDecoration border color changes only from Theme or changing the whole Border, so i have made a changes on the Whole decorations in the TextBox.
For Your Knowledge: I don't know why I did this pull request maybe I was drunk maybe I was sleepy