Minor: simplification of example. #1018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm new to fluent_ui and as I was reading through the example I found it to be slightly harder to follow than necessary. These are my suggestions to streamline the initial exposure.
|
It took me three days to figure out how the home page works. The main issue with this demonstration is the duplicated information required by the go_router and pane_items. One possible solution is grouping navgation prompting, routing and page building together. By supplying builders for either go_router or pane_item, the reduction of total complexity could have been archive. |
|
Hey @hunt978 , I did notice and appreciate that part too. That said, I didn't dare to change that part. I wasn't sure if that was maybe intentional to demonstrate the use of gorouter as a popular package 🤷 |
bdlukaa
requested changes
Feb 6, 2024
Comment on lines
-516
to
-523
| paneBodyBuilder: (item, child) { | ||
| final name = | ||
| item?.key is ValueKey ? (item!.key as ValueKey).value : null; | ||
| return FocusTraversalGroup( | ||
| key: ValueKey('body$name'), | ||
| child: widget.child, | ||
| ); | ||
| }, |
There was a problem hiding this comment.
Why was this removed? This is important to keep the focus on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to fluent_ui and as I was reading through the example I found it to be slightly harder to follow than necessary. These are my suggestions to streamline the initial exposure. Nothing much of substance.
EDIT: I also took the liberty to include footer items into the auto suggestions.
Pre-launch Checklist
CHANGELOG.mdwith my changes