Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support derived Animate classes in order to use the same axes. #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tahsinkose
Copy link

Hello there,

I've been using the MATLAB version of these nice toolboxes and just recently finally had a use-case to migrate to Python. I needed to visualize multiple frames in a single animation view. In order to do that, I have to derive from base.animate.Animate and adjust some of the internal data structures. In order to use the same ax as base.animate.Animate does, however, I had to clone this repo and make this change so that all derived classes receive the exact same treatment with the base class.
multiple_frames

@tahsinkose
Copy link
Author

@jhavl this is a rather simple yet capable improvement that provides trivial extensibility of Animate classes. Could you please give it a quick look and merge? 🙏🏼

Cc. @petercorke

@petercorke
Copy link
Collaborator

Looks great! I'll have a look at the change on the weekend. There's more I'd like to do with animations but this seems like a win. Thx for your interest

@tahsinkose
Copy link
Author

@petercorke friendly ping 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants