[Issue-122] Pass shortest arg for interp; optionally enforce non-negative scalar … #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcao-bdai
requested review from
petercorke,
jhavl and
myeatman-bdai
as code owners
jcao-bdai
force-pushed
the
pass-shortest-interp-arg
branch
from
3b6e6e7
to
6664937
Compare
myeatman-bdai
requested changes
May 13, 2024
spatialmath/base/transforms2d.py
Outdated
| @@ -937,6 +943,10 @@ def trinterp2(start, end, s): | |||
|
|
|||
| th0 = math.atan2(start[1, 0], start[0, 0]) | |||
| th1 = math.atan2(end[1, 0], end[0, 0]) | |||
| if shortest: | |||
| delta = (th1 - th0 + math.pi) % (math.pi * 2) - math.pi | |||
There was a problem hiding this comment.
lets make this a function if the code is dupllicated twice
There was a problem hiding this comment.
found an existing function - updates are pushed in 55a650c
jcao-bdai
force-pushed
the
pass-shortest-interp-arg
branch
from
e83f30e
to
55a650c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements changes from discussions under Issue 122.