Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/devsu 2269 update access checks #463

Merged
merged 29 commits into from May 16, 2024

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented May 7, 2024

Updates germline, unreviewed and nonproduction access checks to use the germline, unreviewed and nonproduction access groups (instead of the 'isExternal' value which depended on the user having the roles 'collaborator' or 'clinician').

In the user groups view, removes display of groups other than the core groups that are referenced in api and client code (admin, manager, report manager, bioinformatician, readonly, germline access, unreviewed access, and nonproduction access).

Removes display and ability to edit group 'owner'.

Removes ability to add or delete groups, or to change their names (since the api and client actually depend on the groups named above having those exact names, and do not make any use of other user groups).

@elewis2 elewis2 marked this pull request as draft May 7, 2024 00:57
Copy link

github-actions bot commented May 7, 2024

Test Results

    1 files  ±0    28 suites  ±0   4m 46s ⏱️ +2s
145 tests ±0  145 ✔️ ±0  0 💤 ±0  0 ±0 
142 runs  ±0  142 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit b03b323. ± Comparison against base commit 0c60b57.

♻️ This comment has been updated with latest results.

@elewis2 elewis2 marked this pull request as ready for review May 16, 2024 20:34
@elewis2 elewis2 requested a review from sshugsc May 16, 2024 20:45
app/components/Sidebar/index.tsx Outdated Show resolved Hide resolved
app/views/ProjectsView/index.tsx Outdated Show resolved Hide resolved
app/views/AdminView/components/Groups/index.tsx Outdated Show resolved Hide resolved
app/views/ProjectsView/index.tsx Outdated Show resolved Hide resolved
app/views/ReportView/index.tsx Outdated Show resolved Hide resolved
app/views/ReportsView/index.tsx Outdated Show resolved Hide resolved
@elewis2 elewis2 merged commit 4d1a5ae into develop May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants