New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/devsu 2269 update access checks #463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat/DEVSU-2269-update-access-checks
…to feat/DEVSU-2269-update-access-checks
….com/bcgsc/pori_ipr_client into feat/DEVSU-2269-update-access-checks
…to feat/DEVSU-2269-update-access-checks
bnguyen-bcgsc
requested changes
May 16, 2024
app/views/ProjectsView/components/AddEditProjectDialog/index.tsx
Outdated
Show resolved
Hide resolved
….com/bcgsc/pori_ipr_client into feat/DEVSU-2269-update-access-checks
bnguyen-bcgsc
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates germline, unreviewed and nonproduction access checks to use the germline, unreviewed and nonproduction access groups (instead of the 'isExternal' value which depended on the user having the roles 'collaborator' or 'clinician').
In the user groups view, removes display of groups other than the core groups that are referenced in api and client code (admin, manager, report manager, bioinformatician, readonly, germline access, unreviewed access, and nonproduction access).
Removes display and ability to edit group 'owner'.
Removes ability to add or delete groups, or to change their names (since the api and client actually depend on the groups named above having those exact names, and do not make any use of other user groups).